Skip to content

build llvm with systemz backend enabled, and link to related libraries#36080

Merged
bors merged 1 commit into
rust-lang:masterfrom
japaric:systemz
Aug 29, 2016
Merged

build llvm with systemz backend enabled, and link to related libraries#36080
bors merged 1 commit into
rust-lang:masterfrom
japaric:systemz

Conversation

@japaric

@japaric japaric commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

when building rust against system llvm

closes #36077

r? @alexcrichton

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

#define SUBTARGET_PPC
#endif

#ifdef LLVM_COMPONENT_SYSTEMZ

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to related libraries when building rust against system llvm

this fixes the travis builds. We could add a build slave that tests building rust against system llvm to avoid these in the future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build slave

I meant bors. Travis doesn't block PRs.

@japaric

japaric commented Aug 28, 2016

Copy link
Copy Markdown
Contributor Author

cc @TimNN

@alexcrichton

Copy link
Copy Markdown
Member

Thanks @japaric! I'll wait to r+ until travis is green

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Aug 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 15d8dfb has been approved by alexcrichton

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15d8dfb with merge 06ab76a...

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1

arielb1 commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@bors retry

@arielb1

arielb1 commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@bors p=1

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 15d8dfb with merge 77d2cd2...

bors added a commit that referenced this pull request Aug 29, 2016
build llvm with systemz backend enabled, and link to related libraries

when building rust against system llvm

closes #36077

r? @alexcrichton
@bors bors merged commit 15d8dfb into rust-lang:master Aug 29, 2016
@japaric japaric deleted the systemz branch August 29, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis is failing ("undefined reference to LLVMInitializeSystemZ*")

5 participants